wsry commented on a change in pull request #10492: [FLINK-15140][runtime] Fix
shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r356555096
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferConsumer.java
##########
@@ -44,42 +44,58 @@
private int currentReaderPosition;
+ /** Whether the underlying {@link Buffer} can be shared by multi {@link
BufferConsumer} instances. */
+ private final boolean isShareable;
Review comment:
By tag the BufferConsumer as shareable, I mean underlying buffer can be
shared in the future, not the buffer is shared immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
