wsry commented on a change in pull request #10492: [FLINK-15140][runtime] Fix
shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r355830724
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -169,7 +169,7 @@ BufferAndBacklog pollBuffer(boolean isLocalChannel) {
BufferConsumer bufferConsumer = buffers.peek();
buffer = bufferConsumer.build();
- if (!isLocalChannel && canBeCompressed(buffer))
{
+ if (!isLocalChannel &&
!bufferConsumer.isCopied() && canBeCompressed(buffer)) {
Review comment:
I can replace the "isCopied" or "isCopyable" with "isBufferShared" which may
be easier to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
