zhijiangW commented on a change in pull request #10492: [FLINK-15140][runtime]
Fix shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r356429397
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ChannelSelectorRecordWriter.java
##########
@@ -101,7 +101,7 @@ public BufferBuilder requestNewBufferBuilder(int
targetChannel) throws IOExcepti
checkState(bufferBuilders[targetChannel] == null ||
bufferBuilders[targetChannel].isFinished());
BufferBuilder bufferBuilder =
targetPartition.getBufferBuilder();
-
targetPartition.addBufferConsumer(bufferBuilder.createBufferConsumer(),
targetChannel);
+
targetPartition.addBufferConsumer(bufferBuilder.createBufferConsumer(false),
targetChannel);
Review comment:
nit: if we do not make this change and still use previous
`createBufferConsumer`, then we can also avoid adding `@VisibleForTesting`
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
