zhijiangW commented on a change in pull request #10492: [FLINK-15140][runtime]
Fix shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r356435083
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferConsumer.java
##########
@@ -44,42 +44,58 @@
private int currentReaderPosition;
+ /** Whether the underlying {@link Buffer} can be shared by multi {@link
BufferConsumer} instances. */
+ private final boolean isShareable;
Review comment:
`{@link Buffer}` here is not very accurate because we have two cases for
tagging this field as true.
- `bufferBuilder.createBufferConsumer(true)`: in this case, every created
`BufferConsumer` refers to different `Buffer` instances
- `BufferConsumer#copy()`: only in this case the underlying `Buffer` is
shared by other instances.
So maybe we adjust the description as `Whether the respective writable
{@link BufferBuilder} is shared .....`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
