zhijiangW commented on a change in pull request #10492: [FLINK-15140][runtime]
Fix shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r356444335
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferBuilderTestUtils.java
##########
@@ -67,18 +67,22 @@ public static Buffer buildSingleBuffer(BufferConsumer
bufferConsumer) {
}
public static BufferConsumer createFilledFinishedBufferConsumer(int
dataSize) {
- return createFilledBufferConsumer(dataSize, dataSize, true);
+ return createFilledBufferConsumer(dataSize, dataSize, true,
true);
Review comment:
Why changed the previous tests to use the `isShareable` property by default?
The shareable property is not the general scenarios and is only used for
broadcast with compression. So it is enough to only cover the compression case
for verifying. The most common cases should be non-shareable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
