wangyang0918 commented on a change in pull request #10616: [FLINK-15288] 
Starting jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361388864
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
 ##########
 @@ -56,14 +56,14 @@
                        " Its not possible to use this configuration key to 
define port ranges.");
 
        /**
-        * Percentage of heap space to remove from containers (YARN / Mesos), 
to compensate
+        * Percentage of heap space to remove from containers (YARN / Mesos/ 
Kubernetes), to compensate
         * for other JVM memory usage.
         */
        public static final ConfigOption<Float> CONTAINERIZED_HEAP_CUTOFF_RATIO 
= ConfigOptions
 
 Review comment:
   Yes, you are right. Currently, the cutoff is only effective for jobmanager. 
And i think we do need to rename it, because it will be deprecated soon. You 
could the discussion under https://issues.apache.org/jira/browse/FLINK-15288.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to