wangyang0918 commented on a change in pull request #10616: [FLINK-15288]
Starting jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361391450
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesUtilsTest.java
##########
@@ -144,6 +147,15 @@ public void testGetJobManagerStartCommand() {
" " + mainClass + " " + mainClassArgs + " " +
jmLogRedirects,
getJobManagerStartCommand(cfg, true, true,
mainClassArgs));
+
cfg.setInteger(ResourceManagerOptions.CONTAINERIZED_HEAP_CUTOFF_MIN, 300);
Review comment:
I will remove this part of checking cutoff. Just as you say, it has already
be checked by its own tests.
We always try to reuse `getJobManagerExpectedCommand`. However, when we
change the `CONTAINER_START_COMMAND_TEMPLATE` and test the behavior, we could
not reuse it. They do not share lots of common codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
