wangyang0918 commented on a change in pull request #10616: [FLINK-15288]
Starting jobmanager pod should respect containerized.heap-cutoff
URL: https://github.com/apache/flink/pull/10616#discussion_r361396883
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -640,4 +641,30 @@ public static String getDynamicProperties(Configuration
baseConfig, Configuratio
.toArray(String[]::new);
return String.join(" ", newAddedConfigs);
}
+
+ /**
+ * Calculate heap size after cut-off.
+ */
+ public static int calculateHeapSize(int memory,
org.apache.flink.configuration.Configuration conf) {
Review comment:
Currently, the only usage of calculating cutoff heap size is to set `-Xmx
-Xms` for jobmanager start command. So i intend to update the description of
this method to reflect this. When we refactor the memory configuration for
jobmanager based on FLIP-49, we could reconsider whether we need a separate
class for jobmanager resource utils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
