pnowojski commented on a change in pull request #10332:
[FLINK-13905][checkpointing] Separate checkpoint triggering into several
asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r363079887
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -648,24 +636,17 @@ public boolean isShutdown() {
return checkpoint.getCompletionFuture();
}
catch (Throwable t) {
- // guard the map against concurrent modifications
- synchronized (lock) {
- pendingCheckpoints.remove(checkpointID);
- }
-
int numUnsuccessful =
numUnsuccessfulCheckpointsTriggers.incrementAndGet();
LOG.warn("Failed to trigger checkpoint {} for job {}.
({} consecutive failed attempts so far)",
checkpointID, job, numUnsuccessful, t);
- if (!checkpoint.isDiscarded()) {
- failPendingCheckpoint(checkpoint,
CheckpointFailureReason.TRIGGER_CHECKPOINT_FAILURE, t);
- }
-
- try {
- checkpointStorageLocation.disposeOnFailure();
Review comment:
What has happened to this line? Was it replaced by something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
