pnowojski commented on a change in pull request #10332:
[FLINK-13905][checkpointing] Separate checkpoint triggering into several
asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r363080156
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -363,10 +361,9 @@ public void shutdown(JobStatus jobStatus) throws
Exception {
masterHooks.clear();
// clear and discard all pending checkpoints
- for (PendingCheckpoint pending :
pendingCheckpoints.values()) {
- failPendingCheckpoint(pending,
CheckpointFailureReason.CHECKPOINT_COORDINATOR_SHUTDOWN);
- }
- pendingCheckpoints.clear();
+ abortPendingCheckpoints(
+ new CheckpointException(
+
CheckpointFailureReason.CHECKPOINT_COORDINATOR_SHUTDOWN));
Review comment:
it looks like before `triggerQueuedRequests` was not called here (and in
some other places), while it's called now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
