pnowojski commented on a change in pull request #10332:
[FLINK-13905][checkpointing] Separate checkpoint triggering into several
asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r363081508
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -162,9 +162,9 @@
* Non-volatile, because only accessed in synchronized scope */
private boolean periodicScheduling;
- /** Flag whether a trigger request could not be handled immediately.
Non-volatile, because only
- * accessed in synchronized scope */
- private boolean triggerRequestQueued;
+ /** Flag whether periodic triggering is suspended (too many concurrent
pending checkpoint).
+ * Non-volatile, because only accessed in synchronized scope */
+ private boolean periodicTriggeringSuspended;
Review comment:
Could you rephrase and elaborate the commit message
```
Actually the newcome trigger request will be failed if there are too many
pending checkpoints.
It's more like suspending periodic triggering rather than queuing.
And the semantic of queuing will be used in later commit.
```
? I'm struggling to understand the motivation behind this commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
