wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365635974
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -30,7 +30,7 @@ function cleanup {
kubectl delete job flink-job-cluster
kubectl delete service flink-job-cluster
kubectl delete deployment flink-task-manager
- rm -rf ${OUTPUT_VOLUME}
Review comment:
The `${OUTPUT_VOLUME}` is under `${TEST_DATA_DIR}`. And `${TEST_DATA_DIR}`
will be cleaned up automatically when the e2e test finished. See
`test-runner-common.sh#cleanup`.
I will add a hotfix to remove this line. Then it will be more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
