wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365636347
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_session.sh
##########
@@ -29,6 +29,7 @@ ARGS="--output ${OUTPUT_PATH}"
function cleanup {
kubectl delete service ${CLUSTER_ID}
kubectl delete clusterrolebinding ${CLUSTER_ROLE_BINDING}
+ stop_kubernetes
Review comment:
Nice suggestion. I will create a follow-up ticket to optimize the start/stop
of minikube.
BTW, i think the Yarn/Mesos/Kubernetes share the logics. Start a new cluster
for each e2e test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
