wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365636347
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_session.sh
##########
@@ -29,6 +29,7 @@ ARGS="--output ${OUTPUT_PATH}"
function cleanup {
kubectl delete service ${CLUSTER_ID}
kubectl delete clusterrolebinding ${CLUSTER_ROLE_BINDING}
+ stop_kubernetes
Review comment:
Nice suggestion.
If we use `--vm-driver=none` when starting a minikube in linux-like system,
it is very fast(less than 5s). Most of the time cost at building the flink
image and then running the test. The advantage is we always get a new and clean
Kubernetes cluster environment for every test.
BTW, i think the Yarn/Mesos/Kubernetes share the logics. Start a new cluster
for each e2e test.
So i will create a follow-up ticket tracking the optimization and it is not
urgent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
