tillrohrmann commented on a change in pull request #10850:
[FLINK-15519][configuration] Preserve logs from BashJavaUtils and make them
part of TM logs
URL: https://github.com/apache/flink/pull/10850#discussion_r369151878
##########
File path: flink-dist/src/main/flink-bin/bin/taskmanager.sh
##########
@@ -49,20 +49,33 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP ==
"start-foreground" ]]; then
# Startup parameters
- jvm_params=$(getTmResourceJvmParams)
+ jvm_params_output=`runBashJavaUtilsCmd GET_TM_RESOURCE_JVM_PARAMS
${FLINK_CONF_DIR}`
+ jvm_params=`extractExecutionParams "$jvm_params_output"`
if [[ $? -ne 0 ]]; then
echo "[ERROR] Could not get JVM parameters properly."
exit 1
fi
export JVM_ARGS="${JVM_ARGS} ${jvm_params}"
IFS=$" "
- dynamic_configs=($(getTmResourceDynamicConfigs))
+
+ dynamic_configs_output=`runBashJavaUtilsCmd
GET_TM_RESOURCE_DYNAMIC_CONFIGS ${FLINK_CONF_DIR}`
+ dynamic_configs=`extractExecutionParams "$dynamic_configs_output"`
Review comment:
This is out of scope for this PR but I'm wondering why we need to call the
utility twice. This will generate almost the same diagnostic output twice which
will appear in the main process logs. I'd suggest to rework this as a follow up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
