tillrohrmann commented on a change in pull request #10850: 
[FLINK-15519][configuration] Preserve logs from BashJavaUtils and make them 
part of TM logs
URL: https://github.com/apache/flink/pull/10850#discussion_r369100714
 
 

 ##########
 File path: flink-dist/src/main/flink-bin/bin/config.sh
 ##########
 @@ -42,6 +42,26 @@ constructFlinkClassPath() {
     echo "$FLINK_CLASSPATH""$FLINK_DIST"
 }
 
+findFlinkDistJar() {
+    local FLINK_DIST
+
+    while read -d '' -r jarfile ; do
 
 Review comment:
   I agree with Gary. The current logic seems a bit too complicated for the job 
it is doing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to