tillrohrmann commented on a change in pull request #10850:
[FLINK-15519][configuration] Preserve logs from BashJavaUtils and make them
part of TM logs
URL: https://github.com/apache/flink/pull/10850#discussion_r369150944
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -603,38 +623,32 @@ TMSlaves() {
runBashJavaUtilsCmd() {
local cmd=$1
- local class_path=$2
- local conf_dir=$3
- local EXECUTION_PREFIX="BASH_JAVA_UTILS_EXEC_RESULT:"
+ local conf_dir=$2
+ local
class_path="${3:-$FLINK_BIN_DIR/bash-java-utils.jar:`findFlinkDistJar`}"
+ class_path=`manglePathList ${class_path}`
- local output=`${JAVA_RUN} -classpath ${class_path}
org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} |
tail -n 1`
+ local output=`${JAVA_RUN} -classpath ${class_path}
org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} |
tail -n 1000`
Review comment:
```suggestion
local output=`${JAVA_RUN} -classpath ${class_path}
org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2>&1
| tail -n 1000`
```
In order to make the exception appear in order with the other logging
statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
