Chesnay Schepler created FLINK-15740:
----------------------------------------

             Summary: Remove Deadline#timeLeft()
                 Key: FLINK-15740
                 URL: https://issues.apache.org/jira/browse/FLINK-15740
             Project: Flink
          Issue Type: Improvement
          Components: API / DataStream, Tests
            Reporter: Chesnay Schepler
             Fix For: 1.11.0


As shown in FLINK-13662, {{Deadline#timeLeft()}} is conceptually broken since 
there is no reliable way to call said method while ensuring that
 a) the value is non-negative (desired since most time-based APIs reject 
negative values)
 b) the value sign (+,-) corresponds to preceding calls to {{#hasTimeLeft()}}

 

As a result any usage of the following form is unreliable and obfuscating error 
messages.
{code:java}
while (deadline.hasTimeLeft()) {
        doSomething(deadline.timeLeft());
} {code}
 

All existing usage should be migrate to either
{code:java}
while (deadline.hasTimeLeft()) {
        doSomething();
} {code}
or
{code:java}
while (true) {
        doSomething(deadline.timeLeftIfAny());
}
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to