JingsongLi commented on a change in pull request #10960: [FLINK-15487][table]
Update code generation for new type inference
URL: https://github.com/apache/flink/pull/10960#discussion_r373754686
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
##########
@@ -694,38 +702,70 @@ object CodeGenUtils {
}
}
+ /**
+ * Generates code for converting the given external source data type to the
internal data format.
+ *
+ * Use this function for converting at the edges of the API.
+ */
def genToInternalIfNeeded(
ctx: CodeGeneratorContext,
- t: DataType,
- term: String): String = {
- if (isInternalClass(t)) {
- s"(${boxedTypeTermForType(fromDataTypeToLogicalType(t))}) $term"
+ sourceDataType: DataType,
+ externalTerm: String)
+ : GeneratedExpression = {
+ val sourceType = sourceDataType.getLogicalType
+ val sourceClass = sourceDataType.getConversionClass
+ // convert external source type to internal format
+ val internalResultTerm = if (isInternalClass(sourceDataType)) {
+ s"$externalTerm"
} else {
- genToInternal(ctx, t, term)
+ genToInternal(ctx, sourceDataType, externalTerm)
+ }
+ // extract null term from result term
+ if (sourceClass.isPrimitive) {
+ generateNonNullField(sourceType, internalResultTerm)
Review comment:
I have some concerns that the user has returned primitive conversion class,
but the real java method return non-primitive which could be null.
What kind of errors will we give users at this time? Maybe we can add a test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
