dawidwys commented on a change in pull request #10960: [FLINK-15487][table]
Update code generation for new type inference
URL: https://github.com/apache/flink/pull/10960#discussion_r373860042
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -570,37 +570,40 @@ object GenerateUtils {
* Wrapper types can autoboxed to their corresponding primitive type
(Integer -> int).
*
* @param ctx code generator context which maintains various code
statements.
- * @param fieldType type of field
- * @param fieldTerm expression term of field to be unboxed
+ * @param inputType type of field
+ * @param inputTerm expression term of field to be unboxed
+ * @param inputUnboxingTerm unboxing/conversion term
* @return internal unboxed field representation
*/
def generateInputFieldUnboxing(
ctx: CodeGeneratorContext,
- fieldType: LogicalType,
- fieldTerm: String): GeneratedExpression = {
+ inputType: LogicalType,
+ inputTerm: String,
+ inputUnboxingTerm: String)
Review comment:
I don't fully understand this change, but do we really need that parameter?
Shouldn't we only ever check for null and assign value from the same input?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
