dawidwys commented on a change in pull request #10960: [FLINK-15487][table]
Update code generation for new type inference
URL: https://github.com/apache/flink/pull/10960#discussion_r373519202
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/DataTypeExtractor.java
##########
@@ -305,8 +305,12 @@ private DataType extractDataTypeOrError(DataTypeTemplate
template, List<Type> ty
DataTypeTemplate template,
List<Type> typeHierarchy,
Type type) {
+ // byte arrays have higher priority than regular arrays
Review comment:
nit: How about a comment like: `prefer VARBINARY/BYTES() over ARRAY(TINYINT)
for bytes[]` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
