wuchong commented on a change in pull request #10745:
[FLINK-15445][connectors/jdbc] JDBC Table Source didn't work for Type…
URL: https://github.com/apache/flink/pull/10745#discussion_r376199069
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialect.java
##########
@@ -35,6 +37,15 @@
*/
boolean canHandle(String url);
+ /**
+ * Check if this dialect instance support a specific data type in table
schema.
+ *
+ * @param schema the table schema
+ */
+ default void validate(TableSchema schema) {
Review comment:
throws `ValidationException` on the method signature. And please add a
description about the exception in the javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services