wuchong commented on a change in pull request #10745: 
[FLINK-15445][connectors/jdbc] JDBC Table Source didn't work for Type…
URL: https://github.com/apache/flink/pull/10745#discussion_r377619154
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
 ##########
 @@ -71,43 +71,48 @@ public void validate(TableSchema schema) throws 
ValidationException {
                                //  
PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO in 
LegacyTypeInfoDataTypeConverter
                                //  when n is smaller than Integer.MAX_VALUE
                                if 
(unsupportedTypes().contains(dt.getLogicalType().getTypeRoot()) ||
-                                               (!(dt.getLogicalType() 
instanceof LegacyTypeInformationType) &&
-                                               (VARBINARY == 
dt.getLogicalType().getTypeRoot()
-                                                       && Integer.MAX_VALUE != 
((VarBinaryType) dt.getLogicalType()).getLength()))) {
+                                               (dt.getLogicalType() instanceof 
VarBinaryType
+                                                       && Integer.MAX_VALUE != 
((VarBinaryType) dt.getLogicalType()).getLength())) {
                                        throw new ValidationException(
-                                                       String.format("The 
dialect don't support type: %s.", dt.toString()));
+                                                       String.format("The %s 
dialect don't support type: %s.",
 
 Review comment:
   Nit: don't -> doesn't

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to