wuchong commented on a change in pull request #10745:
[FLINK-15445][connectors/jdbc] JDBC Table Source didn't work for Type…
URL: https://github.com/apache/flink/pull/10745#discussion_r376204154
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
##########
@@ -50,11 +60,36 @@
private static final long serialVersionUID = 1L;
+ private static final int MAX_DERBY_DECIMAL_PRECISION = 31;
+
+ private static final int MIN_DERBY_DECIMAL_PRECISION = 1;
Review comment:
Could you add a comment above these constants that includes documentation
link describes the precision? So that we can have the single truth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
