wangyang0918 commented on a change in pull request #10980: 
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r376200422
 
 

 ##########
 File path: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
 ##########
 @@ -684,12 +710,28 @@ private static void start(YarnConfiguration conf, String 
principal, String keyta
 
        }
 
+       private static void setMiniDFSCluster(String principal, String keytab, 
File targetTestClassesFolder) throws Exception {
 
 Review comment:
   Why do you leave the unused two arguments `principal` and `keytab`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to