wangyang0918 commented on a change in pull request #10980: 
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r376199849
 
 

 ##########
 File path: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
 ##########
 @@ -376,6 +384,14 @@ public static void writeYarnSiteConfigXML(Configuration 
yarnConf, File targetFol
                }
        }
 
+       private static void writeHDFSCoreSiteConfigXML(Configuration coreSite, 
File targetFolder) throws IOException {
 
 Review comment:
   Maybe the name `writeHDFSSiteConfigXML` makes more senses. Since we do not 
write the `core-site.xml` file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to