wangyang0918 commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r376217472
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -682,6 +683,10 @@ private ApplicationReport startAppMaster(
// add user code jars from the provided JobGraph
: jobGraph.getUserJars().stream().map(f ->
f.toUri()).map(File::new).collect(Collectors.toSet());
+ int yarnFileReplication =
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY,
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+ int fileReplication =
flinkConfiguration.getInteger(YarnConfigOptions.FILE_REPLICATION);
Review comment:
Do you have a test to update the `DFS_REPLICATION_KEY` in hdfs-site.xml? And
then the replication here should be same. I am not sure we could get a updated
value from `yarnConfiguration`. Since `YarnConfiguration` do not add the
`hdfs-site.xml` as resource by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
