lirui-apache commented on a change in pull request #10730:
[FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376203398
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveVectorizedOrcSplitReader.java
##########
@@ -62,18 +61,30 @@ public HiveVectorizedOrcSplitReader(
throw new IllegalArgumentException("Unknown split type:
" + hadoopSplit);
}
- this.reader = genPartColumnarRowReader(
- hiveVersion,
- conf,
- fieldNames,
- fieldTypes,
-
split.getHiveTablePartition().getPartitionSpec(),
- selectedFields,
- new ArrayList<>(),
- DEFAULT_SIZE,
- new Path(fileSplit.getPath().toString()),
- fileSplit.getStart(),
- fileSplit.getLength());
+ this.reader = hiveVersion.startsWith("1.") ?
+
org.apache.flink.orc.nohive.OrcSplitReaderUtil.genPartColumnarRowReader(
Review comment:
Can we have a different class name like `OrcNoHiveSplitReaderUtil `? Having
to differentiate classes by package path is not very friendly to developers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
