lirui-apache commented on a change in pull request #10730:
[FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376233882
##########
File path:
flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcSplitReader.java
##########
@@ -44,23 +44,23 @@
* Orc split reader to read record from orc file. The reader is only
responsible for reading the data
* of a single split.
*/
-public abstract class OrcSplitReader<T> implements Closeable {
+public abstract class OrcSplitReader<T, BATCH extends OrcVectorizedBatch>
implements Closeable {
private final OrcShim shim;
Review comment:
`OrcShim<BATCH>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services