lirui-apache commented on a change in pull request #10730:
[FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r377427396
##########
File path:
flink-formats/flink-orc/src/main/java/org/apache/flink/orc/shim/OrcShim.java
##########
@@ -46,22 +47,24 @@ RecordReader createRecordReader(
long splitStart,
long splitLength) throws IOException;
+ OrcVectorizedBatchWrapper<BATCH> createBatchWrapper(TypeDescription
schema, int batchSize);
+
/**
* Read the next row batch.
*/
- boolean nextBatch(RecordReader reader, VectorizedRowBatch rowBatch)
throws IOException;
+ boolean nextBatch(RecordReader reader, BATCH rowBatch) throws
IOException;
/**
* Default with orc dependent, we should use v2.3.0.
*/
- static OrcShim defaultShim() {
+ static OrcShimV230 defaultShim() {
Review comment:
Can we change the return type to `OrcShim<VectorizedRowBatch>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
