[
https://issues.apache.org/jira/browse/FLINK-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038294#comment-17038294
]
Timo Walther commented on FLINK-16117:
--------------------------------------
We shouldn't use DDL to define test input data. Plain strings are even harder
to maintain. Instead, we should work on a good testing catalog with a couple of
predefined tables containing data sets that target different use cases (one
with all data types, one with small number of rows, one with a lot of rows).
> Avoid register source in TableTestBase#addTableSource
> -----------------------------------------------------
>
> Key: FLINK-16117
> URL: https://issues.apache.org/jira/browse/FLINK-16117
> Project: Flink
> Issue Type: Sub-task
> Reporter: Zhenghua Gao
> Assignee: Zhenghua Gao
> Priority: Major
>
> This affects thousands of unit tests:
> 1) explainSourceAsString of CatalogSourceTable changes
> 2)JoinTest#testUDFInJoinCondition: SQL keywords must be escaped
> 3) GroupWindowTest#testTimestampEventTimeTumblingGroupWindowWithProperties:
> Reference to a rowtime or proctime window required
> 4) SetOperatorsTest#testInWithProject: legacy type vs new type
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
