[
https://issues.apache.org/jira/browse/FLINK-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038319#comment-17038319
]
Jark Wu commented on FLINK-16117:
---------------------------------
I didn't mean to use DDL to define test input data, I mean just define the
table. The test data can be placed in a global map, and the reference the data
via map key in the DDL.
I also agree to have a catalog with a copule of predefined tables, I'm tired of
the {{a, b, c}} columns, and have to understand new tables for each tests.
Calcite is a good example, e.g.
{{org.apache.calcite.test.CalciteAssert.SchemaSpec}}.
> Avoid register source in TableTestBase#addTableSource
> -----------------------------------------------------
>
> Key: FLINK-16117
> URL: https://issues.apache.org/jira/browse/FLINK-16117
> Project: Flink
> Issue Type: Sub-task
> Reporter: Zhenghua Gao
> Assignee: Zhenghua Gao
> Priority: Major
>
> This affects thousands of unit tests:
> 1) explainSourceAsString of CatalogSourceTable changes
> 2)JoinTest#testUDFInJoinCondition: SQL keywords must be escaped
> 3) GroupWindowTest#testTimestampEventTimeTumblingGroupWindowWithProperties:
> Reference to a rowtime or proctime window required
> 4) SetOperatorsTest#testInWithProject: legacy type vs new type
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
