[
https://issues.apache.org/jira/browse/FLINK-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039189#comment-17039189
]
Timo Walther commented on FLINK-16117:
--------------------------------------
Sure, we can use {{tableEnv.connect}} within the testing utilities but should
not expose them. Who knows which changes we will perform to this API in the
future.
Maybe DDL is more stable than API, but we should avoid repetitive work as much
as possible. E.g. maybe we can just call {{util.ddl("CREATE TABLE ()")}}
without a WITH clause?
We could come up with a nice builder pattern that allows to select predefined
tables or add a custom one. Dawid raised also a good point that shared tables
mean that tests are less modular and self-contained, which is also an important
property.
> Avoid register source in TableTestBase#addTableSource
> -----------------------------------------------------
>
> Key: FLINK-16117
> URL: https://issues.apache.org/jira/browse/FLINK-16117
> Project: Flink
> Issue Type: Sub-task
> Reporter: Zhenghua Gao
> Assignee: Zhenghua Gao
> Priority: Major
>
> This affects thousands of unit tests:
> 1) explainSourceAsString of CatalogSourceTable changes
> 2)JoinTest#testUDFInJoinCondition: SQL keywords must be escaped
> 3) GroupWindowTest#testTimestampEventTimeTumblingGroupWindowWithProperties:
> Reference to a rowtime or proctime window required
> 4) SetOperatorsTest#testInWithProject: legacy type vs new type
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
