pnowojski commented on a change in pull request #11098: [FLINK-16060][task]
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r384335505
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -484,11 +485,15 @@ public final void invoke() throws Exception {
}
}
+ protected boolean runMailboxStep() throws Exception {
+ return mailboxProcessor.runMailboxStep();
+ }
+
Review comment:
I don't see how your proposal should work @rkhachatryan ? After passing to
the test harness
```
val streamTask = new TestStreamTask<>(new MultipleInputStreamTask<>(env))
```
every time test harness would access the `streamTask`, it would be accessing
`TestStreamTask`, not `MultipleInputStreamTask`, unless you would
override/delegate all of the methods, which would be an unstable overkill.
I think better solution would be to inject, mailbox into the `StreamTask`,
but that would require to create
`[Source|TwoInput|MultipleInput]StreamTaskBuilder` classes (constructors of
`StreamTask` are already messy), and it's also on an overkill for this (imo)
small problem. I think I would have done, if not for the fact how much
refactoring and clean up I'm already doing here and will be doing more in other
places (`AbstractStreamOperator` :()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
