pnowojski commented on a change in pull request #11098: [FLINK-16060][task]
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r384339354
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
##########
@@ -637,19 +638,24 @@ public StreamNode getStreamNode(Integer vertexID) {
return streamNodes.keySet();
}
+ @VisibleForTesting
public List<StreamEdge> getStreamEdges(int sourceId, int targetId) {
-
List<StreamEdge> result = new ArrayList<>();
for (StreamEdge edge : getStreamNode(sourceId).getOutEdges()) {
if (edge.getTargetId() == targetId) {
result.add(edge);
}
}
+ return result;
+ }
+ @VisibleForTesting
+ @Deprecated
+ public List<StreamEdge> getStreamEdgesOrThrow(int sourceId, int
targetId) {
Review comment:
Yes, we should. As I wrote, the old method shouldn't exists. At least here I
renamed it so it is not so confusing :/
But I didn't want to spend even more time cleaning up unrelated old code
(because I was cleaning up/refactoring already so much).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
