GJL commented on a change in pull request #11213: [FLINK-16276][tests]
Introduce a builder and factory methods to create DefaultScheduler for testing
URL: https://github.com/apache/flink/pull/11213#discussion_r385135983
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -280,23 +281,8 @@ private ExecutionGraph createExecutionGraph(
failoverStrategy);
}
- /**
- * @deprecated Direct access to the execution graph by scheduler
implementations is discouraged
- * because currently the execution graph has various features and
responsibilities that a
- * scheduler should not be concerned about. The following specialized
abstractions to the
- * execution graph and accessors should be preferred over direct access:
- * <ul>
- * <li>{@link #getSchedulingTopology()}
- * <li>{@link #getFailoverTopology()}
- * <li>{@link #getInputsLocationsRetriever()}
- * <li>{@link #getExecutionVertex(ExecutionVertexID)}
- * <li>{@link #getExecutionVertexId(ExecutionAttemptID)}
- * <li>{@link #getExecutionVertexIdOrThrow(ExecutionAttemptID)}
- * </ul>
- * Currently, only {@link LegacyScheduler} requires direct access to
the execution graph.
- */
- @Deprecated
- protected ExecutionGraph getExecutionGraph() {
+ @VisibleForTesting
+ public ExecutionGraph getExecutionGraph() {
Review comment:
> It's a prerequisite change for a set of following PRs so I think we can
avoid adding one more hotfix to make it public then.
If you think it makes your life easier, then we can leave this commit.
However, I would prefer to change the visibility in non-hotfix commit when we
rewrite the first test to use the new scheduler. In the git history it will be
easier to see the justification. Moreover, if we delay rewritig the tests, the
visibility will not be unnecessarily increased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
