azagrebin commented on a change in pull request #11240: [FLINK-16190][e2e]
Migrate tests to FlinkResource
URL: https://github.com/apache/flink/pull/11240#discussion_r385805384
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkResource.java
##########
@@ -52,15 +46,34 @@
*/
ClusterController startCluster(int numTaskManagers) throws IOException;
+ /**
+ * Searches the logs of all processes for the given pattern, and
applies the given processor for every line for
+ * which {@link Matcher#matches()} returned true.
+ *
+ * @param pattern pattern to search for
+ * @param matchProcessor match processor
+ * @return stream of matched strings
+ */
+ Stream<String> searchAllLogs(Pattern pattern, Function<Matcher, String>
matchProcessor) throws IOException;
+
/**
* Returns the configured FlinkResource implementation, or a {@link
LocalStandaloneFlinkResource} if none is configured.
*
* @return configured FlinkResource, or {@link
LocalStandaloneFlinkResource} is none is configured
*/
static FlinkResource get() {
+ return get(FlinkResourceSetup.builder().build());
+ }
+
+ /**
+ * Returns the configured FlinkResource implementation, or a {@link
LocalStandaloneFlinkResource} if none is configured.
+ *
+ * @return configured FlinkResource, or {@link
LocalStandaloneFlinkResource} is none is configured
Review comment:
at least `@param` to make it different from `get()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
