zentol commented on a change in pull request #11240: [FLINK-16190][e2e] Migrate 
tests to FlinkResource
URL: https://github.com/apache/flink/pull/11240#discussion_r385957575
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java
 ##########
 @@ -76,7 +77,9 @@
        }
 
        @Rule
-       public final FlinkResource flink = new LocalStandaloneFlinkResource();
+       public final FlinkResource flink = new 
LocalStandaloneFlinkResourceFactory()
+               .create(FlinkResourceSetup.builder().build())
+               .get();
 
 Review comment:
   These tests have are in some form or another reliant on the cluster running 
locally. In the case of this test IIRC it was because the input CSV file exists 
locally; for the metrics IT case it is because it assumes the JM to be on the 
local host.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to