zentol commented on a change in pull request #11240: [FLINK-16190][e2e] Migrate
tests to FlinkResource
URL: https://github.com/apache/flink/pull/11240#discussion_r385958357
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/FlinkDistribution.java
##########
@@ -261,19 +263,33 @@ public void submitSQLJob(SQLJobSubmission job) throws
IOException {
AutoClosableProcess.runBlocking(commands.toArray(new
String[0]));
}
- public void copyOptJarsToLib(String jarNamePrefix) throws
FileNotFoundException, IOException {
- final Optional<Path> reporterJarOptional;
- try (Stream<Path> logFiles = Files.walk(opt)) {
- reporterJarOptional = logFiles
- .filter(path ->
path.getFileName().toString().startsWith(jarNamePrefix))
+ public void moveJar(JarMove move) throws IOException {
Review comment:
The proposed code is indeed over-engineered for current usages, but we will
soon have operations from opt -> plugins and lib -> opt, and this approach can
handle this easier since it doesn't require additional methods.
I will fix the method not doing a move.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
