TisonKun commented on a change in pull request #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#discussion_r385873950
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -213,20 +210,6 @@ private static Configuration getEffectiveConfiguration(
return effectiveConfiguration;
}
- @Override
- public JobExecutionResult execute(StreamGraph streamGraph) throws
Exception {
- try {
- return super.execute(streamGraph);
- }
- catch (ProgramInvocationException e) {
- throw e;
- }
- catch (Exception e) {
- String term = e.getMessage() == null ? "." : (": " +
e.getMessage());
- throw new ProgramInvocationException("The program
execution failed" + term, e);
Review comment:
Let's say that FLINK-15090 requires remove usage of
`ProgramInvocationException` which belongs to `flink-client` which will then be
no longer a dependency of `flink-streaming`. I don't think user should rely on
`ProgramInvocationException` which itself doesn't keep consistency(always
thrown) among environments. It would be just for display and no harm we use the
`super` implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
