tillrohrmann commented on a change in pull request #11261: [hotfix][streaming]
Clean up redundant & dead code about StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/11261#discussion_r387682415
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -213,20 +210,6 @@ private static Configuration getEffectiveConfiguration(
return effectiveConfiguration;
}
- @Override
- public JobExecutionResult execute(StreamGraph streamGraph) throws
Exception {
- try {
- return super.execute(streamGraph);
- }
- catch (ProgramInvocationException e) {
- throw e;
- }
- catch (Exception e) {
- String term = e.getMessage() == null ? "." : (": " +
e.getMessage());
- throw new ProgramInvocationException("The program
execution failed" + term, e);
Review comment:
I think this change is not as simple as it might look like. By changing the
thrown exception we are effectively changing public API here. Such a change
should definitely not happen as part of a hotfix commit!
Admittedly, the signature says that we are throwing an `Exception` instead
of a `ProgramInvocationException` but until now the `RemoteStreamEnvironment`
contract that it only throws `ProgramInvocationExceptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
