zhijiangW commented on a change in pull request #11400: [FLINK-16586][network]
Build ResultSubpartitionInfo and InputChannelInfo in respective constructors
URL: https://github.com/apache/flink/pull/11400#discussion_r392122559
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionBuilder.java
##########
@@ -40,6 +40,8 @@
private BoundedBlockingSubpartitionType blockingSubpartitionType =
BoundedBlockingSubpartitionType.AUTO;
+ private int partitionIndex = 0;
Review comment:
This builder is only for testing purpose, and I do not think this property
is more important or very necessary than other existing fields like
`partitionId`, `numberOfSubpartitions` etc. Even I guess this new field is rare
used for most of the testing cases, so I prefer to not making it as mandatory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
