rkhachatryan commented on a change in pull request #11400:
[FLINK-16586][network] Build ResultSubpartitionInfo and InputChannelInfo in
respective constructors
URL: https://github.com/apache/flink/pull/11400#discussion_r392126894
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -217,6 +218,7 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
for (InputGateDeploymentDescriptor igdd :
inputGateDeploymentDescriptors) {
SingleInputGate inputGate =
singleInputGateFactory.create(
ownerContext.getOwnerName(),
+ counter,
Review comment:
Here, we rely on iteration order (`counter`), but the type of
`inputGateDeploymentDescriptors` is `Collection`.
When it is created it is `List` though.
So I think we should change the type of
`TaskDeploymentDescriptor.inputGates` and all parameters down to
`inputGateDeploymentDescriptors` to `List`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
