rkhachatryan commented on a change in pull request #11400:
[FLINK-16586][network] Build ResultSubpartitionInfo and InputChannelInfo in
respective constructors
URL: https://github.com/apache/flink/pull/11400#discussion_r392291325
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -217,6 +218,7 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
for (InputGateDeploymentDescriptor igdd :
inputGateDeploymentDescriptors) {
SingleInputGate inputGate =
singleInputGateFactory.create(
ownerContext.getOwnerName(),
+ counter,
Review comment:
Not sure if I got you right.
I meant to change the type from `Collection` to `List` for:
1. `inputGateDeploymentDescriptors` parameter in
`NettyShuffleEnvironment#createInputGates`
1. `TaskDeploymentDescriptor#inputGates` field
1. `inputGateDeploymentDescriptors` parameter in `Task` constructor
1. `inputGateDeploymentDescriptors` parameter in `TaskDeploymentDescriptor`
constructor
Without it, it's easy to break the ordering, at least for me :)
I think it should be the same PR because requirement for ordering was added
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
