zhijiangW commented on a change in pull request #11400: [FLINK-16586][network] Build ResultSubpartitionInfo and InputChannelInfo in respective constructors URL: https://github.com/apache/flink/pull/11400#discussion_r392777741
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java ########## @@ -217,6 +218,7 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext( for (InputGateDeploymentDescriptor igdd : inputGateDeploymentDescriptors) { SingleInputGate inputGate = singleInputGateFactory.create( ownerContext.getOwnerName(), + counter, Review comment: I thought you were referring to the unnecessary transformation in the logics before, sorry for misunderstanding. You are right that the current `Collection` actually does not provide any order guarantee which relies on the subclass interface (`List` or `Set`), and we indeed need the determined order after restarting. It is reasonable to adjust the `Collection` to `List` as you suggested, but the only trouble is that it would change the public interface of `ShuffleEnvironment` proposed in FLIP-31. So it might break the compatibility if some outside users already relied on it. I guess it needs to discussion in ML for finalization. Anyway, I already addressed this issue in a separate commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services