kaibozhou commented on a change in pull request #11250: [FLINK-16302][rest]add
log list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r393724492
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/AbstractTaskManagerFileHandler.java
##########
@@ -263,4 +264,10 @@ private void transferFile(ChannelHandlerContext ctx, File
file, HttpRequest http
throw new FlinkException("Could not transfer file " +
file + " to the client.", ioe);
}
}
+
+ protected String getFileName(HandlerRequest<EmptyRequestBody, M>
handlerRequest) {
+ return "undefined";
Review comment:
What is the fileName used for? default value？
It should be considered here whether a special approach is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
