kaibozhou commented on a change in pull request #11250: [FLINK-16302][rest]add
log list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r393712257
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/AbstractTaskManagerFileHandler.java
##########
@@ -118,9 +119,11 @@ protected AbstractTaskManagerFileHandler(
protected CompletableFuture<Void>
respondToRequest(ChannelHandlerContext ctx, HttpRequest httpRequest,
HandlerRequest<EmptyRequestBody, M> handlerRequest, RestfulGateway gateway)
throws RestHandlerException {
final ResourceID taskManagerId =
handlerRequest.getPathParameter(TaskManagerIdPathParameter.class);
+ String filename = getFileName(handlerRequest);
+ final Tuple2<ResourceID, String> taskManagerId2FileName = new
Tuple2<>(taskManagerId, filename);
Review comment:
I personally prefer to use `taskManagerIdAndFileName` instead of
`taskManagerId2FileName`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
