kaibozhou commented on a change in pull request #11250: [FLINK-16302][rest]add
log list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r393692076
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -582,16 +582,41 @@ public void notifySlotAvailable(
}
@Override
- public CompletableFuture<TransientBlobKey>
requestTaskManagerFileUpload(ResourceID taskManagerId, FileType fileType, Time
timeout) {
- log.debug("Request file {} upload from TaskExecutor {}.",
fileType, taskManagerId);
+ public CompletableFuture<TransientBlobKey>
requestTaskManagerFileUploadByType(ResourceID taskManagerId, FileType fileType,
Time timeout) {
+ log.debug("Request file which type is {} upload from
TaskExecutor {}.", fileType, taskManagerId);
Review comment:
```suggestion
log.debug("Request file of type {} upload from TaskExecutor
{}.", fileType, taskManagerId);
```
Note: there are more than one space between `}` and `upload` in your log.
I'm not a native speaker, so this is just a suggestion IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
