tillrohrmann commented on a change in pull request #10362:
[FLINK-14792][coordination] Implement TE cluster partition release
URL: https://github.com/apache/flink/pull/10362#discussion_r394496886
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/TaskExecutorPartitionTrackerImplTest.java
##########
@@ -150,6 +150,27 @@ public void stopTrackingAndReleaseAllClusterPartitions()
throws Exception {
assertThat(shuffleReleaseFuture.get(),
hasItem(resultPartitionId1));
}
+ @Test
+ public void stopTrackingAndReleaseClusterPartitions() throws Exception {
+ final TestingShuffleEnvironment testingShuffleEnvironment = new
TestingShuffleEnvironment();
+ final CompletableFuture<Collection<ResultPartitionID>>
shuffleReleaseFuture = new CompletableFuture<>();
+ testingShuffleEnvironment.releasePartitionsLocallyFuture =
shuffleReleaseFuture;
Review comment:
It is not part of this PR but this looks like code smell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
