tillrohrmann commented on a change in pull request #10362:
[FLINK-14792][coordination] Implement TE cluster partition release
URL: https://github.com/apache/flink/pull/10362#discussion_r394493200
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
##########
@@ -50,7 +51,7 @@
/**
* {@link TaskExecutor} RPC gateway interface.
*/
-public interface TaskExecutorGateway extends RpcGateway,
TaskExecutorOperatorEventGateway {
+public interface TaskExecutorGateway extends RpcGateway,
TaskExecutorOperatorEventGateway, ClusterPartitionHolder {
Review comment:
If `TaskExecutorGateway` extends `ClusterPartitionHolder`, then
`releaseClusterPartitions` is a RPC, right? If this is the case, then the
method should get a `@RpcTimeout` because remote procedure calls can always
fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
